[webkit-reviews] review granted: [Bug 211065] [JSC] >>> should call ToNumeric : [Attachment 397662] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 211065: [JSC] >>> should call ToNumeric
https://bugs.webkit.org/show_bug.cgi?id=211065

Attachment 397662: Patch

https://bugs.webkit.org/attachment.cgi?id=397662&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 397662
  --> https://bugs.webkit.org/attachment.cgi?id=397662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397662&action=review

r=me

It would be good to have a spec link in the ChangeLog.
Presumably: https://tc39.es/ecma262/#sec-unsigned-right-shift-operator

> Source/JavaScriptCore/ChangeLog:10
> +	   since the only difference between toUint32 and toInt32 is casting
int32_t result to uint32_t.

This is interesting.

It's funny that this comment claims that there will be an explanation:
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/runtime/JSCJ
SValueInlines.h#L56
But it must have been removed?
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/runtime/JSCJ
SValue.h#L293