[webkit-reviews] review granted: [Bug 211073] [GTK4] Add support for motion events : [Attachment 397675] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 211073: [GTK4] Add support for motion events
https://bugs.webkit.org/show_bug.cgi?id=211073

Attachment 397675: Patch

https://bugs.webkit.org/attachment.cgi?id=397675&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 397675
  --> https://bugs.webkit.org/attachment.cgi?id=397675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397675&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1136
> +    // FIXME: Forward event to dialog.

Wouldn't this be “if (priv->dialog) return GDK_EVENT_PROPAGATE;” like
in the function right above? If so, I think we should do it already for
this patch and remove this FIXME.

> Tools/MiniBrowser/gtk/BrowserTab.c:410
> +#if !GTK_CHECK_VERSION(3, 98, 0)

How about removing the margin also for GTK3 so we don't need the #if here?