[webkit-reviews] review granted: [Bug 210939] Caret may be placed in the wrong spot for text input context that is a form control : [Attachment 397635] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 210939: Caret may be placed in the wrong spot for text input context that
is a form control
https://bugs.webkit.org/show_bug.cgi?id=210939

Attachment 397635: Patch

https://bugs.webkit.org/attachment.cgi?id=397635&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 397635
  --> https://bugs.webkit.org/attachment.cgi?id=397635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397635&action=review

> Source/WebCore/editing/Editing.cpp:568
> +    RenderObject* renderer = element.renderer();

Getting the renderer before update layout is always a risky proposition. This
might be an element that was display none until now and was just changed.

> Source/WebCore/editing/Editing.cpp:570
> +    if (!renderer)
> +	   return { };

This isn’t needed. The second null check below is sufficient.