[webkit-reviews] review granted: [Bug 211029] [JSC] Add fast path for BigInt32 left-shift : [Attachment 397581] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted  review:
Bug 211029: [JSC] Add fast path for BigInt32 left-shift
https://bugs.webkit.org/show_bug.cgi?id=211029

Attachment 397581: Patch

https://bugs.webkit.org/attachment.cgi?id=397581&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 397581
  --> https://bugs.webkit.org/attachment.cgi?id=397581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397581&action=review

Nice. r=me

>> Source/JavaScriptCore/runtime/Operations.h:776
>> +		int64_t result64 = static_cast<int64_t>(leftInt32) <<
rightInt32;
> 
> you need to check if this is a left shift, right?

sorry, I missed the above !isLeft branch