[webkit-reviews] review granted: [Bug 210944] Reduce use of WebPageProxy::VoidCallback : [Attachment 397503] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 25 11:23:14 PDT 2020


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 210944: Reduce use of WebPageProxy::VoidCallback
https://bugs.webkit.org/show_bug.cgi?id=210944

Attachment 397503: Patch

https://bugs.webkit.org/attachment.cgi?id=397503&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 397503
  --> https://bugs.webkit.org/attachment.cgi?id=397503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397503&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2314
> +   
sendWithAsyncReply(Messages::WebPage::ExecuteEditCommandWithCallback(commandNam
e, argument), [callbackFunction = WTFMove(callbackFunction), backgroundActivity
=
m_process->throttler().backgroundActivity("WebPageProxy::executeEditCommand"_s)
] () mutable {

One last case of () that you didn't delete yet.


More information about the webkit-reviews mailing list