[webkit-reviews] review granted: [Bug 210990] Rendering update steps should use Seconds for the timestamps : [Attachment 397552] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 25 08:14:13 PDT 2020


Daniel Bates <dbates at webkit.org> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 210990: Rendering update steps should use Seconds for the timestamps
https://bugs.webkit.org/show_bug.cgi?id=210990

Attachment 397552: Patch

https://bugs.webkit.org/attachment.cgi?id=397552&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 397552
  --> https://bugs.webkit.org/attachment.cgi?id=397552
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397552&action=review

Patch looks good.

> Source/WebCore/dom/Document.cpp:7679
> +		       (*timestamp).milliseconds(),

Ok as is. No change needed. Optimal solution is to use -> because it is more
idiomatic and aestically pleasing.


More information about the webkit-reviews mailing list