[webkit-reviews] review granted: [Bug 210879] AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet : [Attachment 397547] patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 210879: AX: Improve tracking of Element* pointers in AXObjectCache with
WeakHashSet
https://bugs.webkit.org/show_bug.cgi?id=210879

Attachment 397547: patch

https://bugs.webkit.org/attachment.cgi?id=397547&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 397547
  --> https://bugs.webkit.org/attachment.cgi?id=397547
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397547&action=review

Patch looks good.

> Source/WebCore/accessibility/AXObjectCache.h:490
> +    WeakHashSet<Element> m_deferredRecomputeIsIgnoredList;

This is a behavior change: weak set is UNORDERED, but list set is ORDERED. Is
this OK?