[webkit-reviews] review granted: [Bug 211012] Suppress ASan on DFG::clobberize() to work around an ASan bug. : [Attachment 397545] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 23:59:35 PDT 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 211012: Suppress ASan on DFG::clobberize() to work around an ASan bug.
https://bugs.webkit.org/show_bug.cgi?id=211012

Attachment 397545: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=397545&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 397545
  --> https://bugs.webkit.org/attachment.cgi?id=397545
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=397545&action=review

r=me

> Source/JavaScriptCore/dfg/DFGClobberize.h:43
> +SUPPRESS_ASAN void clobberize(Graph& graph, Node* node, const ReadFunctor&
read, const WriteFunctor& write, const DefFunctor& def)

Can you add FIXME comment describing why SUPPRESS_ASAN is necessary (describing
about ASAN bug)?


More information about the webkit-reviews mailing list