[webkit-reviews] review granted: [Bug 211010] Use static initialized Lock instead of LazyNeverDestroyed<Lock> : [Attachment 397543] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 23:05:38 PDT 2020


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 211010: Use static initialized Lock instead of LazyNeverDestroyed<Lock>
https://bugs.webkit.org/show_bug.cgi?id=211010

Attachment 397543: Patch

https://bugs.webkit.org/attachment.cgi?id=397543&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 397543
  --> https://bugs.webkit.org/attachment.cgi?id=397543
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review

r=me

> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110
> +static Lock deviceMutex;

Why not just declare it as a static inside its accessor function?  Ditto below.


More information about the webkit-reviews mailing list