[webkit-reviews] review granted: [Bug 210937] [iOS] Fix sandbox violation when uploading a file : [Attachment 397511] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 210937: [iOS] Fix sandbox violation when uploading a file
https://bugs.webkit.org/show_bug.cgi?id=210937

Attachment 397511: Patch

https://bugs.webkit.org/attachment.cgi?id=397511&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 397511
  --> https://bugs.webkit.org/attachment.cgi?id=397511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397511&action=review

> Source/WebKit/Shared/ios/WebIconUtilities.mm:95
> +    if (![interactionController.icons count])
> +	   return nullptr;

How does this change relate to the rest? No comment in the change log to
explain it. Definitely not obvious.

Do we have to carefully call this before the extension is revoked?

Also, UIImage * return value would normally be a nil, not *.

Also, looks like there is a mistake in thumbnailSizedImageForImage, which
should return a RetainPtr<UIImage> or should retain/autorelease the result of
UIGraphicsGetImageFromCurrentImageContext. Given that name it doesn’t sound
safe to keep the pointer around before deallocating the image context.