[webkit-reviews] review granted: [Bug 211005] Update svg/batik/text/xmlSpace.svg to yield consistent text metrics : [Attachment 397531] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 24 17:43:07 PDT 2020
Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 211005: Update svg/batik/text/xmlSpace.svg to yield consistent text metrics
https://bugs.webkit.org/show_bug.cgi?id=211005
Attachment 397531: Patch
https://bugs.webkit.org/attachment.cgi?id=397531&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 397531
--> https://bugs.webkit.org/attachment.cgi?id=397531
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=397531&action=review
> LayoutTests/ChangeLog:12
> + The test is rendering a bunch of characters without using a
specified font.
> + This means that Core Text is picking an arbitrary font. However, the
> + -expected.txt file is measuring exact pixel widths. The solution is
to just
> + give the test an explicit fallback font.
Good fix for the test, I guess.
But is it compatible web behavior to let "Core Text" pick an *arbitrary* font?
More information about the webkit-reviews
mailing list