[webkit-reviews] review granted: [Bug 210922] Return BigInt32 whenever we can : [Attachment 397523] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 210922: Return BigInt32 whenever we can
https://bugs.webkit.org/show_bug.cgi?id=210922

Attachment 397523: patch

https://bugs.webkit.org/attachment.cgi?id=397523&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 397523
  --> https://bugs.webkit.org/attachment.cgi?id=397523
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397523&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:555
> +	   } else if (node->binaryUseKind() == HeapBigIntUse) {

Use `node->isBinaryUseKind(HeapBigIntUse)`.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:560
> +	   } else if (node->binaryUseKind() == AnyBigIntUse)

Ditto.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:750
> +	   if (node->binaryUseKind() == HeapBigIntUse) {

Use `node->isBinaryUseKind(HeapBigIntUse)`.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:755
> +	   } else if (node->binaryUseKind() == AnyBigIntUse ||
node->binaryUseKind() == BigInt32Use)

Use `node->isBinaryUseKind(AnyBigIntUse) ||
node->isBinaryUseKind(BigInt32Use)`.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1024
> +	   if (node->binaryUseKind() == HeapBigIntUse) {

Use `node->isBinaryUseKind(HeapBigIntUse)`.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1029
> +	   } else if (node->binaryUseKind() == AnyBigIntUse ||
node->binaryUseKind() == BigInt32Use)

Ditto.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1040
> +	   if (node->binaryUseKind() == HeapBigIntUse) {

Ditto.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1045
> +	   } else if (node->binaryUseKind() == AnyBigIntUse ||
node->binaryUseKind() == BigInt32Use)

Ditto.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1109
> +	   if (node->binaryUseKind() == HeapBigIntUse) {

Ditto.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1114
> +	   } else if (node->binaryUseKind() == AnyBigIntUse ||
node->binaryUseKind() == BigInt32Use)

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3748
> +    if (node->binaryUseKind() == HeapBigIntUse) {

`node->isBinaryUseKind(HeapBigIntUse)` would be better.

> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

Just remove it. This is already covered by existing tests.