[webkit-reviews] review granted: [Bug 210979] check-webkit-style should recognize *Internal.h and *Private.h as primary headers : [Attachment 397472] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 11:09:35 PDT 2020


Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 210979: check-webkit-style should recognize *Internal.h and *Private.h as
primary headers
https://bugs.webkit.org/show_bug.cgi?id=210979

Attachment 397472: Patch v1

https://bugs.webkit.org/attachment.cgi?id=397472&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 397472
  --> https://bugs.webkit.org/attachment.cgi?id=397472
Patch v1

When making changes like this I like the idea of running check-webkit-style
across the whole source tree, but there are probably *so* many messages when
doing that, it’s not a great thing.


More information about the webkit-reviews mailing list