[webkit-reviews] review granted: [Bug 210917] fast/scrolling/scroll-behavior-invalidate-if-disabled.html is a flaky failure : [Attachment 397438] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 10:03:53 PDT 2020


Darin Adler <darin at apple.com> has granted cathiechen <cathiechen at igalia.com>'s
request for review:
Bug 210917: fast/scrolling/scroll-behavior-invalidate-if-disabled.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=210917

Attachment 397438: Patch

https://bugs.webkit.org/attachment.cgi?id=397438&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 397438
  --> https://bugs.webkit.org/attachment.cgi?id=397438
Patch

OK. I think we could refactor this a bit more dividing into one more function
that does the disabled check after parsing, so the end of the function was
shared between the cached and non-cashed case.


More information about the webkit-reviews mailing list