[webkit-reviews] review granted: [Bug 210956] [JSC] DFG AI for some bitops + BigInt32 should be precise : [Attachment 397437] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 210956: [JSC] DFG AI for some bitops + BigInt32 should be precise
https://bugs.webkit.org/show_bug.cgi?id=210956

Attachment 397437: Patch

https://bugs.webkit.org/attachment.cgi?id=397437&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 397437
  --> https://bugs.webkit.org/attachment.cgi?id=397437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397437&action=review

r=me.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:543
>	   // FIXME: this use of binaryUseKind means that we cannot specialize
to (for example) a HeapBigInt left-operand and a BigInt32 right-operand.

Can we file a bug for this?