[webkit-reviews] review granted: [Bug 210911] Nullptr crash in objc_msgSend under WebCore::genericFamily : [Attachment 397424] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 09:03:15 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 210911: Nullptr crash in objc_msgSend under WebCore::genericFamily
https://bugs.webkit.org/show_bug.cgi?id=210911

Attachment 397424: patch

https://bugs.webkit.org/attachment.cgi?id=397424&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 397424
  --> https://bugs.webkit.org/attachment.cgi?id=397424
patch

r=me

You could declare the lambda "[&]() -> String" to maintain the existing
one-liner return. Not sure if we like being that fancy or not.


More information about the webkit-reviews mailing list