[webkit-reviews] review granted: [Bug 210954] Use @isUndefinedOrNull instead of abstract equality with null : [Attachment 397430] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 210954: Use @isUndefinedOrNull instead of abstract equality with null
https://bugs.webkit.org/show_bug.cgi?id=210954

Attachment 397430: Patch

https://bugs.webkit.org/attachment.cgi?id=397430&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 397430
  --> https://bugs.webkit.org/attachment.cgi?id=397430
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397430&action=review

r=me with comment.

> Source/JavaScriptCore/ChangeLog:14
> +	   b) Replaces 3 `!= @undefined` and 7 `!= null` comparisons with
@isUndefinedOrNull()
> +	   as only the latter is correct with [[IsHTMLDDA]] aka
MasqueradesAsUndefined objects [2].

Can you add a test with IsHTMLDDA? jsc shell has IsHTMLDDA mechanism so we can
write a test for MasqueradesAsUndefined with JSC shell.