[webkit-reviews] review granted: [Bug 210942] [Win] Bundle Inspector Resources in Release builds : [Attachment 397400] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 23 16:59:49 PDT 2020
Fujii Hironori <Hironori.Fujii at sony.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 210942: [Win] Bundle Inspector Resources in Release builds
https://bugs.webkit.org/show_bug.cgi?id=210942
Attachment 397400: patch
https://bugs.webkit.org/attachment.cgi?id=397400&action=review
--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 397400
--> https://bugs.webkit.org/attachment.cgi?id=397400
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=397400&action=review
> Source/WebInspectorUI/CMakeLists.txt:3
> + ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/*.html
I prefer ${CMAKE_CURRENT_SOURCE_DIR} to
${CMAKE_SOURCE_DIR}/Source/WebInspectorUI,
becuase WebKit might be built as submodule of other project.
More information about the webkit-reviews
mailing list