[webkit-reviews] review granted: [Bug 208849] [PlayStation] Enable TestWTF and TestWebCore : [Attachment 396260] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 208849: [PlayStation] Enable TestWTF and TestWebCore
https://bugs.webkit.org/show_bug.cgi?id=208849

Attachment 396260: Patch

https://bugs.webkit.org/attachment.cgi?id=396260&action=review




--- Comment #8 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 396260
  --> https://bugs.webkit.org/attachment.cgi?id=396260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396260&action=review

Overall looks good. Just have the one nit and its good to go.

> Tools/TestWebKitAPI/playstation/main.cpp:42
> +    dlopen("libicu", RTLD_NOW);
> +    dlopen("libpng16", RTLD_NOW);
> +    dlopen("libfontconfig", RTLD_NOW);
> +    dlopen("libfreetype", RTLD_NOW);
> +    dlopen("libharfbuzz", RTLD_NOW);
> +    dlopen("libcairo", RTLD_NOW);
> +    dlopen("libSceNKWebKitRequirements", RTLD_NOW);
> +    dlopen("libJavaScriptCore", RTLD_NOW);
> +    dlopen("libWebKit", RTLD_NOW);
> +    return TestWebKitAPI::TestsController::singleton().run(argc, argv) ?
EXIT_SUCCESS : EXIT_FAILURE;

You should guard what shared objects it tries to load based on the test being
run. Each executable should define BUILDING_${name} which you can use to only
load the applicable libraries.