[webkit-reviews] review granted: [Bug 209515] [WebGL2] Update texture packing code for software uploads from DOM : [Attachment 397290] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 209515: [WebGL2] Update texture packing code for software uploads from DOM
https://bugs.webkit.org/show_bug.cgi?id=209515

Attachment 397290: Patch

https://bugs.webkit.org/attachment.cgi?id=397290&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 397290
  --> https://bugs.webkit.org/attachment.cgi?id=397290
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397290&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4338
> +    uint8_t* data = reinterpret_cast<uint8_t*>(
> +	   pixels ? pixels->baseAddress() : nullptr); // NEEDS_PORT

We tend to do this on one line.