[webkit-reviews] review denied: [Bug 208814] [GPUP][GTK] compile GPUProcess in GTK port : [Attachment 397179] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has denied Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 208814: [GPUP][GTK] compile GPUProcess in GTK port
https://bugs.webkit.org/show_bug.cgi?id=208814

Attachment 397179: Patch

https://bugs.webkit.org/attachment.cgi?id=397179&action=review




--- Comment #22 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 397179
  --> https://bugs.webkit.org/attachment.cgi?id=397179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397179&action=review

Is there a specific reason you decided to add PLATFORM(COCOA) guards? If all
that needs to be done is fill out some stubs for gstreamer then I think you
should do that. I'm just being a stickler with it because once there's PLATFORM
guards they never really go away.

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:76
> +#if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)

Is there a reason why this should be Cocoa specific?

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:367
> +#if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)

Ditto

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:512
> +#if PLATFORM(COCOA)
>      userMediaCaptureManagerProxy().setOrientation(orientation);
> +#endif

Ditto