[webkit-reviews] review granted: [Bug 210156] [ Mac iOS ] animations/animation-direction-normal.html is a flaky failure : [Attachment 397350] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 210156: [ Mac iOS ] animations/animation-direction-normal.html is a flaky
failure
https://bugs.webkit.org/show_bug.cgi?id=210156

Attachment 397350: Patch

https://bugs.webkit.org/attachment.cgi?id=397350&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 397350
  --> https://bugs.webkit.org/attachment.cgi?id=397350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397350&action=review

> LayoutTests/animations/resources/animation-test.js:34
> +	   this._target = options.target;

"target" is a bit generic. Maybe targetProperty?

> LayoutTests/animations/resources/animation-test.js:91
> +	   // Reset the animation.
> +	   animation.cancel();
> +
> +	   // Make sure it's in the paused state for seeking.
> +	   animation.pause();

Is the cancel then pause really necessary?