[webkit-reviews] review granted: [Bug 209587] Move applyUserAgentIfNeeded calls to a more central place : [Attachment 397229] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 209587: Move applyUserAgentIfNeeded calls to a more central place
https://bugs.webkit.org/show_bug.cgi?id=209587

Attachment 397229: Patch

https://bugs.webkit.org/attachment.cgi?id=397229&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 397229
  --> https://bugs.webkit.org/attachment.cgi?id=397229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397229&action=review

>>> Source/WebCore/loader/cache/CachedResourceLoader.h:178
>>> +	 void updateHTTPRequestHeaders(FrameLoader&, CachedResource::Type,
CachedResourceRequest&);
>> 
>> This doesn’t seem good.
> 
> Can you expand on what is not good? This is the original patch plus the fix
to loadResourceSynchronously.

Having to pass a FrameLoader here bothers me. But it’s not really about this
one patch.