[webkit-reviews] review granted: [Bug 210854] [GTK][WPE] White-list more GStreamer environment variables in webkitpy : [Attachment 397186] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 210854: [GTK][WPE] White-list more GStreamer environment variables in
webkitpy
https://bugs.webkit.org/show_bug.cgi?id=210854

Attachment 397186: Patch

https://bugs.webkit.org/attachment.cgi?id=397186&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 397186
  --> https://bugs.webkit.org/attachment.cgi?id=397186
Patch

Patch LGTM.

Related comment, but not for addressing in this patch: It would be neat if we
could unify the list of whitelisted environment variables for both the GTK and
WPE ports, keep them in a list, then iterate over it in common code instead of
repeating a bunch of calls to “_copy_value_from_environ_if_set()” ��️