[webkit-reviews] review granted: [Bug 210676] REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots : [Attachment 397288] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 210676: REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing
out on macOS bots
https://bugs.webkit.org/show_bug.cgi?id=210676

Attachment 397288: Patch

https://bugs.webkit.org/attachment.cgi?id=397288&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 397288
  --> https://bugs.webkit.org/attachment.cgi?id=397288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397288&action=review

Patch looks good. A better patch would audit all of the unit tests and fix this
up. For future thought, design to prevent this kind of mistake or detect it.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:89
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);

This ok as-is. No change needed. Optimal solution would use auto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:59
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:119
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 640, 480) configuration:configuration.get()]);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:62
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);

Ditto.