[webkit-reviews] review granted: [Bug 210774] Support toggling debug overlay for touch action region and editable element region independent from non-fast scrollable region : [Attachment 397038] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 210774: Support toggling debug overlay for touch action region and editable
element region independent from non-fast scrollable region
https://bugs.webkit.org/show_bug.cgi?id=210774

Attachment 397038: Patch

https://bugs.webkit.org/attachment.cgi?id=397038&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 397038
  --> https://bugs.webkit.org/attachment.cgi?id=397038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397038&action=review

> Source/WebCore/ChangeLog:8
> +	   Break out the touch action region and editable element region debug
overlays into there own

their

> Source/WebCore/ChangeLog:19
> +	   (WebCore::RenderLayerBacking::paintDebugOverlays): Condition the
paintinf of touch action region

painting

>> Source/WebCore/rendering/RenderLayer.cpp:7055
>> +	    if (renderer().settings().visibleDebugOverlayRegions() &
(TouchActionRegion | EditableElementRegion))
> 
> I wanted to make this setting return an OptionSet<>, but that involves some
work due to how settings are generated. For now, I deferred this.

Yeah, that's a shame. It's ok as a mask though.

> Source/WebCore/rendering/RenderLayerBacking.cpp:3088
> +	   Color regionColor(0, 0, 255, 50);

At some point in the future we should collect all our colors into a single
place so we can document them easily.