[webkit-reviews] review granted: [Bug 210873] [iOS] Crash on RunningBoard process assertion invalidation : [Attachment 397276] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 210873: [iOS] Crash on RunningBoard process assertion invalidation
https://bugs.webkit.org/show_bug.cgi?id=210873

Attachment 397276: Patch

https://bugs.webkit.org/attachment.cgi?id=397276&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 397276
  --> https://bugs.webkit.org/attachment.cgi?id=397276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397276&action=review

>> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:292
>> +	    WKRBSAssertionDelegate *strongSelf = weakSelf;
> 
> Hopefully this is what Darin meant by using strongSelf. Geoff recommended
doing this to avoid races.

Yes, this is what I meant. Not sure it’s needed, but this is the pattern I have
seen before.