[webkit-reviews] review granted: [Bug 210862] Remove revoked Proxy checks from ProxyCreate : [Attachment 397222] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 210862: Remove revoked Proxy checks from ProxyCreate
https://bugs.webkit.org/show_bug.cgi?id=210862

Attachment 397222: Patch

https://bugs.webkit.org/attachment.cgi?id=397222&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 397222
  --> https://bugs.webkit.org/attachment.cgi?id=397222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397222&action=review

> JSTests/ChakraCore.yaml:1849
> -  cmd: runChakra :skip, "NoException", "arraywithproxy.baseline", []
> +  cmd: runChakra :skipDueToOutdatedOrBadTest, "NoException", "", []

Whoooa, I didn't know this setting existed. Pretty sure I could have used it in
the past! :D

> Source/JavaScriptCore/ChangeLog:11
> +	   Also cleans up ProxyObject creation by using isFunction() instead of
> +	   isCallable(), which are identical.

Hmm, I wonder if this should be cleaned up for redundancy (in another patch of
course)...

It's odd that isCallable still checks getCallData for JSFunctionType, when it
doesn't look like this could ever be CallType::None.