[webkit-reviews] review granted: [Bug 210863] Add layout test to validate the User-Agent HTTP header of XMLHttpRequest : [Attachment 397219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 22 10:38:28 PDT 2020


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 210863: Add layout test to validate the User-Agent HTTP header of
XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=210863

Attachment 397219: Patch

https://bugs.webkit.org/attachment.cgi?id=397219&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 397219
  --> https://bugs.webkit.org/attachment.cgi?id=397219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397219&action=review

> LayoutTests/http/tests/xmlhttprequest/xhr-user-agent.html:16
> +    shouldBeTrue("syncXHRUserAgent.includes('AppleWebKit/')");

Is it working for non apple port?
Should we use testRunner.setCustomUserAgent?


More information about the webkit-reviews mailing list