[webkit-reviews] review granted: [Bug 210051] [ Mojave wk1 Release ] animations/transition-and-animation-1.html is a flaky failure : [Attachment 397196] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 22 09:03:01 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 210051: [ Mojave wk1 Release ] animations/transition-and-animation-1.html
is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=210051

Attachment 397196: Patch

https://bugs.webkit.org/attachment.cgi?id=397196&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 397196
  --> https://bugs.webkit.org/attachment.cgi?id=397196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397196&action=review

> LayoutTests/animations/transition-and-animation-1.html:23
>	   to	{ -webkit-transform: translateX(300px); }

Might as well remove prefixes too.

> LayoutTests/animations/transition-and-animation-1.html:26
> +    <script src="../resources/ui-helper.js" type="text/javascript"
charset="utf-8"></script>

You can drop the type="text/javascript" charset="utf-8" in this and the next
script tag.


More information about the webkit-reviews mailing list