[webkit-reviews] review granted: [Bug 210051] [ Mojave wk1 Release ] animations/transition-and-animation-1.html is a flaky failure : [Attachment 397194] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 210051: [ Mojave wk1 Release ] animations/transition-and-animation-1.html
is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=210051

Attachment 397194: Patch

https://bugs.webkit.org/attachment.cgi?id=397194&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 397194
  --> https://bugs.webkit.org/attachment.cgi?id=397194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397194&action=review

> LayoutTests/animations/transition-and-animation-1.html:50
> +document.getElementById("box").addEventListener("animationend", event => {
> +    requestAnimationFrame(timestamp => {
> +	   checkExpectedValue(expectedValues, 0);
> +	   endTest();
> +    });
> +});

This would be really nice if you made a re-usable promise-based "animationend"
thing and used async/await here. See UIHelper.animationFrame().