[webkit-reviews] review granted: [Bug 210839] [JSC] AI results of BigInt32 Bitwise shift operation does not match to runtime results : [Attachment 397170] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 210839: [JSC] AI results of BigInt32 Bitwise shift operation does not match
to runtime results
https://bugs.webkit.org/show_bug.cgi?id=210839

Attachment 397170: Patch

https://bugs.webkit.org/attachment.cgi?id=397170&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 397170
  --> https://bugs.webkit.org/attachment.cgi?id=397170
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397170&action=review

> Source/JavaScriptCore/ChangeLog:12
> +	   And we found that FTL BigInt32 predicate is not correctly checking
state. This patch fixes it too.

You should say what the test for this was. A JSValue number might have any
lower bits set.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:546
> +	       // FIXME: We should have inlined implementation that always
returns BigInt32.

link to a bug

> Source/JavaScriptCore/jit/JITOperations.cpp:3152
> +void JIT_OPERATION operationDataLog(EncodedJSValue value)
> +{
> +    dataLogLn(JSValue::decode(value));
> +}

why? Let's remove IMO