[webkit-reviews] review granted: [Bug 210832] [JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse : [Attachment 397151] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 210832: [JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should
expect AnyBigIntUse
https://bugs.webkit.org/show_bug.cgi?id=210832

Attachment 397151: Patch

https://bugs.webkit.org/attachment.cgi?id=397151&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 397151
  --> https://bugs.webkit.org/attachment.cgi?id=397151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422
>  void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool
invert)

Since we may now need to speculate for AnyBigIntUse, the name
nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is
now inaccurate.  I suggest changing them to genericNonPeepholeStrictEq and
genericStrictEq respectively.  "Generic" here being the generic JSValue case. 
Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq?