[webkit-reviews] review granted: [Bug 210819] [Cocoa] Don't bother compiling UpdateInfo since it's not used : [Attachment 397132] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 21 15:46:17 PDT 2020
Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 210819: [Cocoa] Don't bother compiling UpdateInfo since it's not used
https://bugs.webkit.org/show_bug.cgi?id=210819
Attachment 397132: Patch
https://bugs.webkit.org/attachment.cgi?id=397132&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 397132
--> https://bugs.webkit.org/attachment.cgi?id=397132
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=397132&action=review
> Source/WebKit/UIProcess/DrawingAreaProxy.h:55
> +#if USE(COORDINATED_GRAPHICS) || USE(TEXTURE_MAPPER)
> +class UpdateInfo;
> +#endif
Seems overkill to make the forward declaration conditional. OK, but maybe not
necessary to be so careful.
More information about the webkit-reviews
mailing list