[webkit-reviews] review granted: [Bug 210817] [Web Animations] Add a supporting object for Document to manage timelines : [Attachment 397127] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 210817: [Web Animations] Add a supporting object for Document to manage
timelines
https://bugs.webkit.org/show_bug.cgi?id=210817

Attachment 397127: Patch

https://bugs.webkit.org/attachment.cgi?id=397127&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 397127
  --> https://bugs.webkit.org/attachment.cgi?id=397127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397127&action=review

> Source/WebCore/animation/DocumentTimelinesController.cpp:65
> +	   if (!shouldUpdateAnimations && timeline.scheduledUpdate())

Is it expensive to call scheduledUpdate()? if not, skip the
!shouldUpdateAnimations

> Source/WebCore/animation/DocumentTimelinesController.cpp:67
> +	   timelines.append(&timeline);

We don't have a filter method?