[webkit-reviews] review granted: [Bug 210785] [Win] Use generic WorkQueue instead of WorkQueueWin.cpp : [Attachment 397120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 21 14:38:01 PDT 2020


Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 210785: [Win] Use generic WorkQueue instead of WorkQueueWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=210785

Attachment 397120: Patch

https://bugs.webkit.org/attachment.cgi?id=397120&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 397120
  --> https://bugs.webkit.org/attachment.cgi?id=397120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review

> Source/WTF/wtf/WorkQueue.h:35
> -#if USE(COCOA_EVENT_LOOP)
> +#if PLATFORM(COCOA)

Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX)
down to an absolute minimum. Seems sad to move in the other direction.


More information about the webkit-reviews mailing list