[webkit-reviews] review granted: [Bug 210811] Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm : [Attachment 397104] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 210811: Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm
https://bugs.webkit.org/show_bug.cgi?id=210811

Attachment 397104: Patch

https://bugs.webkit.org/attachment.cgi?id=397104&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 397104
  --> https://bugs.webkit.org/attachment.cgi?id=397104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397104&action=review

rs=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-65
> -    auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
> -    EXPECT_EQ([configuration _webViewCategory],
_WKWebViewCategoryAppBoundDomain);

Can you add an explanation to ChangeLog about why this failed? Naively, I would
expect the state of an object that was just init'ed to always the the same, and
not require "initializeInAppBrowserPrivacyTestSettings()".

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-71
> -    [configuration _setWebViewCategory:_WKWebViewCategoryInAppBrowser];
> -    EXPECT_EQ([configuration _webViewCategory],
_WKWebViewCategoryInAppBrowser);
> -
> -    [configuration _setWebViewCategory:_WKWebViewCategoryWebBrowser];
> -    EXPECT_EQ([configuration _webViewCategory],
_WKWebViewCategoryWebBrowser);

Seems OK to move everything, but it may be even better to keep tests for other
categories here.