[webkit-reviews] review granted: [Bug 210810] [Mac] Enable color well tests on Modern WebKit : [Attachment 397101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 21 13:18:40 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 210810: [Mac] Enable color well tests on Modern WebKit
https://bugs.webkit.org/show_bug.cgi?id=210810

Attachment 397101: Patch

https://bugs.webkit.org/attachment.cgi?id=397101&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 397101
  --> https://bugs.webkit.org/attachment.cgi?id=397101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397101&action=review

> LayoutTests/platform/mac-wk1/TestExpectations:189
> +# Color Well is turned off

I know that this is a copied comment, but it still lacks a period.

> LayoutTests/platform/mac/TestExpectations:1581
> +# Originally skipped because color well was turned off. Now it's on for
Modern WebKit on Mac; should figure out how to re-enable these for that case.
>  editing/pasteboard/drag-and-drop-color-input.html [ Skip ]
>  editing/pasteboard/drag-and-drop-color-input-events.html [ Skip ]

It may be better to duplicate these in mac-wk1 and mac-wk2, with mac-wk2 copy
under the "[WK2] [Mac] Support drag in mouse events for WebKit2 EventSender"
section.


More information about the webkit-reviews mailing list