[webkit-reviews] review granted: [Bug 210702] [Cocoa] Use createNSArray in many more places that build NSArray objects from C++ collections : [Attachment 396953] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 210702: [Cocoa] Use createNSArray in many more places that build NSArray
objects from C++ collections
https://bugs.webkit.org/show_bug.cgi?id=210702

Attachment 396953: Patch

https://bugs.webkit.org/attachment.cgi?id=396953&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 396953
  --> https://bugs.webkit.org/attachment.cgi?id=396953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396953&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h:-29
> -#ifndef WebAccessibilityObjectWrapperBase_h

Are we adding #pragma once in objc headers?

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1739
> +	   return nil;

I've been using nullptr instead of nil for RetainPtr because it's a C++ type. 
I guess once we transition to ARC we'll use nil, right?

> Source/WebKitLegacy/mac/History/WebBackForwardList.mm:155
> +constexpr auto WebBackForwardListDictionaryEntriesKey = @"entries";

How do you feel about auto for objc types?  I've tried to avoid it.