[webkit-reviews] review granted: [Bug 209119] [GStreamer][MSE] Youtube 'live stream'/H264 URLs fail to play, VP8/9 URLs play OK : [Attachment 397079] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 209119: [GStreamer][MSE] Youtube 'live stream'/H264 URLs fail to play,
VP8/9 URLs play OK
https://bugs.webkit.org/show_bug.cgi?id=209119

Attachment 397079: Patch

https://bugs.webkit.org/attachment.cgi?id=397079&action=review




--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 397079
  --> https://bugs.webkit.org/attachment.cgi?id=397079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397079&action=review

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:264
> +	   && (!(state == GST_STATE_PLAYING && newState == GST_STATE_PAUSED)
> +	       && !(state == GST_STATE_READY && newState >= GST_STATE_PAUSED)))

"De-morganize" this, please.

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:270
> +	       && (!(state == GST_STATE_PLAYING && newState ==
GST_STATE_PAUSED)
> +		   && !(state == GST_STATE_READY && newState >=
GST_STATE_PAUSED))) {

Ditto.