[webkit-reviews] review granted: [Bug 210673] Horizontal overflow overlay scrollbar is misplaced in RTL : [Attachment 397055] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 210673: Horizontal overflow overlay scrollbar is misplaced in RTL
https://bugs.webkit.org/show_bug.cgi?id=210673

Attachment 397055: Patch

https://bugs.webkit.org/attachment.cgi?id=397055&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 397055
  --> https://bugs.webkit.org/attachment.cgi?id=397055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397055&action=review

r+ but please consider the comment.

> Source/WebCore/rendering/RenderLayer.cpp:3185
> +    IntRect hBarRect, vBarRect, cornerRect, resizerRect;
> +    getOverflowControlsRects(hBarRect, vBarRect, cornerRect, resizerRect);

I'd much prefer a function that returns a struct over one that requires awkward
out parameters.