[webkit-reviews] review granted: [Bug 210777] Fix build failures when video fullscreen and picture-in-picture is disabled : [Attachment 397044] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 19:04:49 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 210777: Fix build failures when video fullscreen and picture-in-picture is
disabled
https://bugs.webkit.org/show_bug.cgi?id=210777

Attachment 397044: Patch

https://bugs.webkit.org/attachment.cgi?id=397044&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 397044
  --> https://bugs.webkit.org/attachment.cgi?id=397044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397044&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:378
> -ENABLE_VIDEO_PRESENTATION_MODE = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE =
$(ENABLE_VIDEO_PRESENTATION_MODE_$(WK_PLATFORM_NAME));
> +ENABLE_VIDEO_PRESENTATION_MODE_iphoneos = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE_watchos = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE_macosx = ENABLE_VIDEO_PRESENTATION_MODE;

As we discussed, this may not be necessary but we can remove it later if
possible.


More information about the webkit-reviews mailing list