[webkit-reviews] review denied: [Bug 210772] Add CFBundleDisplayName to the WebContent XPC service bundle : [Attachment 397039] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 17:36:22 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has denied Luming Yin
<luming_yin at apple.com>'s request for review:
Bug 210772: Add CFBundleDisplayName to the WebContent XPC service bundle
https://bugs.webkit.org/show_bug.cgi?id=210772

Attachment 397039: Patch

https://bugs.webkit.org/attachment.cgi?id=397039&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 397039
  --> https://bugs.webkit.org/attachment.cgi?id=397039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397039&action=review

> Source/WebKit/ChangeLog:10
> +	   Give the WebContent XPC service bundle a localizable
CFBundleDisplayName to make it
> +	   more easily identifiable.

WebContent sets its name dynamically, that's how it uses webpage domain name
for Safari, or includes "Mail" in the name for Mail. 

Adding a static way to do the same appears confusing and thus undesirable.


More information about the webkit-reviews mailing list