[webkit-reviews] review denied: [Bug 210564] Add logging to core accessibility. : [Attachment 397016] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 210564: Add logging to core accessibility.
https://bugs.webkit.org/show_bug.cgi?id=210564

Attachment 397016: Patch

https://bugs.webkit.org/attachment.cgi?id=397016&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 397016
  --> https://bugs.webkit.org/attachment.cgi?id=397016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397016&action=review

> Source/WebCore/accessibility/AXLogger.cpp:64
> +    stream << "objectID: " << object.objectID() << " {\n";
> +    stream << "role: " << static_cast<unsigned>(object.roleValue()) << "\n";
> +    stream << "}";

There are "dumpProperty" helpers that output something like this format.

Also instead of static_cast<unsigned>(object.roleValue()) you should implement
WTF::TextStream& operator<<(WTF::TextStream&, AccessibilityRole);

Better yet, implement  WTF::TextStream& operator<<(WTF::TextStream&, const
AXCoreObject&); and you don't need this function at all.