[webkit-reviews] review granted: [Bug 210764] Intl classes shouldn't need an m_initialized* field : [Attachment 397012] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 210764: Intl classes shouldn't need an m_initialized* field
https://bugs.webkit.org/show_bug.cgi?id=210764

Attachment 397012: Patch

https://bugs.webkit.org/attachment.cgi?id=397012&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 397012
  --> https://bugs.webkit.org/attachment.cgi?id=397012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397012&action=review

> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:61
> +    IntlNumberFormatField(int32_t type, int32_t size)
> +	   : type(type)
> +	   , size(size)
> +    { }

Typically this should not be necessary.

> Source/JavaScriptCore/runtime/IntlPluralRules.cpp:94
>      Vector<String> data;
>      return data;

return { };