[webkit-reviews] review granted: [Bug 210749] [JSC] BigInt constructor can accept out-of-safe-integer range : [Attachment 396993] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 210749: [JSC] BigInt constructor can accept out-of-safe-integer range
https://bugs.webkit.org/show_bug.cgi?id=210749

Attachment 396993: Patch

https://bugs.webkit.org/attachment.cgi?id=396993&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 396993
  --> https://bugs.webkit.org/attachment.cgi?id=396993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396993&action=review

r=me with nit.

> Source/JavaScriptCore/ChangeLog:8
> +	   Maybe, the spec is changed at some point, and now BigInt constructor
accepts non-safe-integers.

Nit, I would phrase this as: Maybe the spec changed at some point but BigInt
constructor accepts non-safe-integers.