[webkit-reviews] review denied: [Bug 210745] [GTK4] Adapt to GtkIconTheme API changes : [Attachment 396974] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied  review:
Bug 210745: [GTK4] Adapt to GtkIconTheme API changes
https://bugs.webkit.org/show_bug.cgi?id=210745

Attachment 396974: Patch

https://bugs.webkit.org/attachment.cgi?id=396974&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 396974
  --> https://bugs.webkit.org/attachment.cgi?id=396974
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396974&action=review

> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:70
> +	   GFile* file = gtk_icon_paintable_get_file(iconPaintable.get());

We need a GRefPtr<GFile> here to avoid leaking the object. The _get_file()
accessor is “transfer full”. You could even do:

  if (auto file = adoptGRef(gtk_icon_paintable_get_file(iconPaintable.get())))
{
      // Load data from file.
  }

=)