[webkit-reviews] review granted: [Bug 210697] [iOS] -_didFinishTextInteractionInTextInputContext should only zoom to reveal focused element if it changed : [Attachment 396872] Patch and tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 210697: [iOS] -_didFinishTextInteractionInTextInputContext should only zoom
to reveal focused element if it changed
https://bugs.webkit.org/show_bug.cgi?id=210697

Attachment 396872: Patch and tests

https://bugs.webkit.org/attachment.cgi?id=396872&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 396872
  --> https://bugs.webkit.org/attachment.cgi?id=396872
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=396872&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5104
> +	   _textInteractionDidChangeFocusedElement |= NO;

Was this intended to be `_textInteractionDidChangeFocusedElement = NO;`? If
not, can we just remove this line?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:583
> +    // Zoom scale of scroll view should change to reveal the focused
element.

I don’t believe this is true for iPad. Maybe we can only do the scale check if
we’re on iPhone?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:605
> +    // Zoom scale of scroll view should change to reveal the focused
element.

Ditto.