[webkit-reviews] review granted: [Bug 210728] StructuredClone algorithm should be aware of BigInt : [Attachment 396950] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 19 23:59:05 PDT 2020


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 210728: StructuredClone algorithm should be aware of BigInt
https://bugs.webkit.org/show_bug.cgi?id=210728

Attachment 396950: Patch

https://bugs.webkit.org/attachment.cgi?id=396950&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 396950
  --> https://bugs.webkit.org/attachment.cgi?id=396950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396950&action=review

r=me

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:3003
> +		   if (digit64 <=
static_cast<uint64_t>((-static_cast<int64_t>(INT32_MIN))))

You can remove 1 set of () around -static_cast<int64_t>(INT32_MIN).


More information about the webkit-reviews mailing list