[webkit-reviews] review granted: [Bug 210727] [JSC] SlowPathCall is not supported by callOperation in Windows : [Attachment 396932] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 210727: [JSC] SlowPathCall is not supported by callOperation in Windows
https://bugs.webkit.org/show_bug.cgi?id=210727

Attachment 396932: Patch

https://bugs.webkit.org/attachment.cgi?id=396932&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 396932
  --> https://bugs.webkit.org/attachment.cgi?id=396932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review

> Source/JavaScriptCore/jit/SlowPathCall.h:68
> +	   static_assert(JIT::regT0 == GPRInfo::returnValueGPR);
> +	   static_assert(JIT::regT1 == GPRInfo::returnValueGPR2);

Should we update this instead?
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.
h#L796-L799